Commit graph

46 commits

Author SHA1 Message Date
Andrew Nicolaou
af1a5cc2f1
Use translations for all tests (#1568)
* Toolbar ARIA Labels
* Ensure all tests use real translations

All tests should import the 'test-utils' file which re-exports all of
the @testing-library functions. It wraps render() in a react-i18next
instance.

It's important that the component being tested is the one returned from
withTranslation().

Co-authored-by: ov <omar.verduga@gmail.com>
2020-08-26 14:19:34 +02:00
Andrew Nicolaou
8308eda7cf
Extract translation keys for Console, Sidebar, FileNode (#1549)
* Convert Console component to use translations

* Extracts Sidebar/FileNode to use English translations

* Mock react-i18next with real English translations
2020-08-19 10:40:05 +01:00
ghalestrilo
df5ac3fb4c make sidebar close on file click 2020-08-07 18:48:39 -03:00
Cassie Tarakajian
763ee140fa [#1526] Fix failing FileNode test 2020-08-05 18:33:40 -04:00
Cassie Tarakajian
a56740c7c4 [#1532] Fix labels for files 2020-08-05 17:50:07 -04:00
Cassie Tarakajian
65bd4b2ff7 [#1526] Refactor FileName component
- Create function parseFileName to separate a file name into first
  letter, last letter, middle, extension
2020-08-03 13:52:07 -04:00
Cassie Tarakajian
937421e90c [#1526] Add ellipsis to sidebar file names 2020-07-30 18:59:12 -04:00
Andrew Nicolaou
9d55fa378a Use testing-library instead of enzyme for tests 2020-06-28 15:44:00 +02:00
Cassie Tarakajian
cee22c3277 Move through svg icons and add aria labels 2020-05-06 14:43:46 -04:00
Cassie Tarakajian
8bf4008c51 Migrate from React-InlineSVG to SVGR 2020-05-06 14:43:46 -04:00
Cassie Tarakajian
2c9fd982d0 Handle whitespace in file name validation 2020-04-16 16:22:59 -04:00
Cassie Tarakajian
41637d2837 Move handleUploadClick from inline function, prevent user from uploading to folder if not authenticated 2020-04-16 16:08:51 -04:00
Cassie Tarakajian
9185447168 Merge master to fix/rename-file-set-unsaved 2020-04-16 15:59:09 -04:00
Cassie Tarakajian
6bf303dfe7 Refactor FileNode.jsx to remove inline functions and match React functional best practices 2020-04-16 15:53:32 -04:00
ghalestrilo
fe9d75be8e 🐛 fix filename allowing empty/invalid strings 2020-04-16 13:08:30 -03:00
ghalestrilo
c4d52457e5 write test file for <FileNode /> 2020-04-16 13:03:21 -03:00
ghalestrilo
ddec33270e 👌 undoing changes, fixing call duplication on FileNode#updateFilename 2020-04-16 10:56:02 -03:00
ghalestrilo
1b083fe54b 👌 move filename change tracking logic to FileNode component state 2020-04-10 13:42:33 -03:00
Cassie Tarakajian
31ca964bb7 Fixes #1361 - upload option missing for folder 2020-04-08 16:18:10 -04:00
ghalestrilo
5df76c249a 🚧 refactor updateFileNmae to thunk, add updatedName param 2020-04-07 20:04:00 -03:00
ghalestrilo
7d05aa78e3 🚧 create updatedName field in files reducer 2020-04-07 19:47:51 -03:00
Cassie Tarakajian
e1a3bf2583 Fixes #1311 2020-04-06 12:46:17 -04:00
Cassie Tarakajian
9d8be89df7
Revert "Revert "fixes #963: fixes bug in which files/folders would get added to"" 2019-10-08 16:39:47 -04:00
Cassie Tarakajian
6a29bd4ce9
Revert "fixes #963: fixes bug in which files/folders would get added to" 2019-10-07 18:23:58 -04:00
Cassie Tarakajian
3360c7c799 fixes #963: fixes bug in which files/folders would get added to selected file (or root), rather than the file that you opened the popover from 2019-10-03 15:51:34 -04:00
Cassie Tarakajian
cc456200a2 prevent users from adding extension to folder name 2019-07-17 12:33:23 -04:00
Rachel Lim
1e5a2b7c51 for 989, updated folder cannot be renamed to empty string 2019-07-17 12:33:23 -04:00
Rachel Lim
4861c03e36 for #989, files cannot be renamed to empty string 2019-07-17 12:33:23 -04:00
Cassie Tarakajian
b3c3efcec9
re #389, update styling in sidebar and editor for icon consistency (#1104)
* re #389, update styling in sidebar and editor for icon consistency

* re #389, remove link to unused icon
2019-06-14 13:30:13 -04:00
Marton Soos
3bf3fe1452 Fix multiple file options showing up (#987) (#988)
* Fix multiple file options showing up (#987)

This change ensures that the file options composite widget is
hidden if and only if none of its components is in focus. This
is achieved by having a variable keep track of the state of
the composite widget (in focus / not in focus).

* Fix #987

Modified fix for #987 according to the requested changes.
Moved isFocused to the components state and created a method
for hadling the function calls executed in onBlur.

* Fix #987 - final touches

Renamed method blurComponent to onBlurComponent. Moved duplicated
code from onFocus callback to a new method called onFocusComponent.
2019-03-27 15:52:57 -04:00
Ankur Ingale
80765e03c7 Fixed Issue #659 (#964)
* Fixed Issue #659

* Undo changes in package.json and package-lock.json

* Resolved error
2019-03-21 17:08:46 -04:00
Cassie Tarakajian
1d2cb87c33 for #874, also fixes bug in which file options could be revealed by right clicking even if user isn't owner of sketch 2019-03-14 16:10:50 -04:00
nimish
a018929489 Remove file menu on blur 2019-03-13 18:10:47 +05:30
Jared Donovan
2f21130e0d Fix needs saving mark 2 - for #576 (#658)
* Comment out show/hide file options action creators.

* Comment out show/hide file options properties

* Comment out show/hide file options action definitions

* Comment out constants for show/hide options action types

* Comment out props for show/hide options and replace with component state.

* Comment out show/hide edit file name reducers.

* Comment out show/hide edit file name actions.

* comment out show/hide edit file name action types.

* Comment out show/edit file name props from IDEView component

* Replace show/hide edit filename props in FileNode component with local state

* Remove commented out code from previous changes for moving redux state back into component state.

* Add binding to this for new functions. And tidy up of code.
2018-09-07 15:48:25 -04:00
Cassie Tarakajian
9efd9c624f fix remaining linting errors 2018-05-08 19:16:05 -07:00
Cassie Tarakajian
c90dac55b7 update eslint and fix linting errors 2018-05-08 19:16:04 -07:00
Dhruvdutt Jadhav
e7abb55ee7 Fixes #515 Update React to 16 and other dependencies (#519)
* Update to react, react-dom 16.2.0

* Update react-redux

* Update react-tabs

* Update redux-devtools

* Update redux-devtools-dock-monitor

* Update redux-devtools-log-monitor

* Add prop-types package

* Update gitignore

* Update all files to use prop-types package

* Update react-router

* Update react-inlinesvg
2018-02-07 13:06:07 -05:00
Andrew Nicolaou
313fc856d1 Fixes linting errors (#362) 2017-06-05 22:33:32 -04:00
Cassie Tarakajian
341ea63437 forgot to commit a file for fix to #347 2017-05-10 13:23:10 -04:00
Cassie Tarakajian
32d3f7a76c allow file names to change case of file extension 2017-04-27 13:08:20 -04:00
Cassie Tarakajian
e87390adb9 update eslint to latest version, fix lots of linting errors (#308)
* update eslint and dependencies, fix linting errors that can be fixed with --fix

* fix lots of linting errors

* update eslintrc, fix some linting errors

* fix all server side linting errors, untested

* fix errors that fixing linting errors had caused

* fix client side eslint errors

* fix client side linting errors

* fix refs lint errors

* fix more linting errors

* update eslint and dependencies, fix linting errors that can be fixed with --fix

* fix lots of linting errors

* update eslintrc, fix some linting errors

* fix all server side linting errors, untested

* fix errors that fixing linting errors had caused

* fix client side eslint errors

* fix client side linting errors

* fix refs lint errors

* fix more linting errors

* fix some accessibility linting errors

* fix a lot of linting errors

* fix a billion more linting errors

* hopefully fix all linting errors, still need to test

* fix bugs that fixing linting had caused
2017-02-22 14:29:35 -05:00
Cassie Tarakajian
54534f68d3 #255 remove unused SidebarItem component, display file dropdown menu when right clicking on sidebar item or project folder 2017-01-09 16:11:01 -05:00
Akarshit Wal
843418e195 toggling menu (#258)
* toggling menu

* Other components should be treated equally
2017-01-09 12:47:32 -05:00
Cassie Tarakajian
637a62be01 fix sidebar bugs 2016-12-09 17:05:24 -05:00
Cassie Tarakajian
c959aec6a9 add commit to hopefully prevent #195 from happening again 2016-11-10 12:26:35 -05:00
Cassie Tarakajian
fc83040c8f remove some dead code/files, change react components to .jsx files because of sublime syntax highlighting, fix linting errors 2016-11-08 18:54:54 -05:00
Renamed from client/modules/IDE/components/FileNode.js (Browse further)