for #874, also fixes bug in which file options could be revealed by right clicking even if user isn't owner of sketch

client/modules/IDE/components/FileNode.jsx

@@ -65,6 +65,9 @@ export class FileNode extends React.Component {
 
   toggleFileOptions(e) {
     e.preventDefault();
+    if (!this.props.canEdit) {
+      return;
+    }
     if (this.state.isOptionsOpen) {
       this.setState({ isOptionsOpen: false });
     } else {
@@ -88,7 +91,7 @@ export class FileNode extends React.Component {
   renderChild(childId) {
     return (
       <li key={childId}>
-        <ConnectedFileNode id={childId} parentId={this.props.id} />
+        <ConnectedFileNode id={childId} parentId={this.props.id} canEdit={this.props.canEdit} />
       </li>
     );
   }
@@ -154,7 +157,6 @@ export class FileNode extends React.Component {
                   tabIndex="0"
                   onClick={this.toggleFileOptions}
                   onBlur={() => setTimeout(this.hideFileOptions, 200)}
-                  style={{ display: (this.state.isOptionsOpen) ? 'inline-block' : '' }}
                 >
                   <InlineSVG src={downArrowUrl} />
                 </button>
@@ -251,7 +253,8 @@ FileNode.propTypes = {
   newFile: PropTypes.func.isRequired,
   newFolder: PropTypes.func.isRequired,
   showFolderChildren: PropTypes.func.isRequired,
-  hideFolderChildren: PropTypes.func.isRequired
+  hideFolderChildren: PropTypes.func.isRequired,
+  canEdit: PropTypes.bool.isRequired
 };
 
 FileNode.defaultProps = {
@@ -262,8 +265,7 @@ FileNode.defaultProps = {
 
 function mapStateToProps(state, ownProps) {
   // this is a hack, state is updated before ownProps
-  return state.files.find(file => file.id === ownProps.id) || { ...ownProps, name: 'test', fileType: 'file' };
-  // return state.files.find(file => file.id === ownProps.id);
+  return state.files.find(file => file.id === ownProps.id) || { name: 'test', fileType: 'file' };
 }
 
 function mapDispatchToProps(dispatch) {

client/modules/IDE/components/Sidebar.jsx

@@ -41,11 +41,12 @@ class Sidebar extends React.Component {
   }
 
   render() {
+    const canEditProject = this.userCanEditProject();
     const sidebarClass = classNames({
       'sidebar': true,
       'sidebar--contracted': !this.props.isExpanded,
       'sidebar--project-options': this.props.projectOptionsVisible,
-      'sidebar--cant-edit': !this.userCanEditProject()
+      'sidebar--cant-edit': !canEditProject
     });
 
     return (
@@ -82,7 +83,10 @@ class Sidebar extends React.Component {
             </ul>
           </div>
         </div>
-        <ConnectedFileNode id={this.props.files.filter(file => file.name === 'root')[0].id} />
+        <ConnectedFileNode
+          id={this.props.files.filter(file => file.name === 'root')[0].id}
+          canEdit={canEditProject}
+        />
       </nav>
     );
   }

client/styles/components/_sidebar.scss

@@ -138,10 +138,16 @@
   }
   .sidebar__file-item:hover > .file-item__content & {
     display: inline-block;
+    .sidebar--cant-edit & {
+      display: none;
+    }
   }
   & svg {
     width: #{10 / $base-font-size}rem;
   }
+  .sidebar__file-item--open > .file-item__content & {
+    display: inline-block;
+  }
 }
 
 .sidebar__file-item-options {