Commit graph

139 commits

Author SHA1 Message Date
ghalestrilo
8ddd7a76e2 Merge branch 'develop' of https://github.com/processing/p5.js-web-editor into feature/mobile-examples 2020-08-07 18:51:37 -03:00
ghalestrilo
229c51238f 🐛 fix navigation problem on IDEView.jsx 2020-08-03 14:35:28 -03:00
Cassie Tarakajian
21761a6e42
Merge branch 'develop' into bug/sidebar-name-overflow 2020-08-03 12:26:40 -04:00
ghalestrilo
d42f10e114 🔀 merge from feature/mobile-header-dropdown-menu 2020-07-31 10:49:19 -03:00
ov
05e43c70b7
Minimal Viable Navigation Menu (#1510)
* Minimal Viable Navigation Menu
Translation with new namespace
I18Next configuration leaning on default separator and namespace

Broom: i18n + debug:false

* Minimal Viable Navigation Menu
Test entry for Toolbar.test.jsx

* Translation.json : Changes in translation for new namespace
About : broom About lines 17-26
Nav component : changes in keys
KeyboardShortcutModal.jsx: Key now in Common

* Voice Over Labels in Preferences:index
Labels included in translations.json

* Voice Over Labels in Preferences:index
Labels included in translations.json

* Voice Over Labels in Preferences:index
Labels included in translations.json

* Voice Over Labels in Preferences:index
Labels included in translations.json
Snapshot updated npm run test -- -u

* translations.json ARIA labels adjacent to respective label
Updated names to call the labels
Common namespace without currently used entries

* Update Nav.jsx

Missing Common.p5logoARIA key

* Update Toolbar.test.jsx

Deleting commented line 78

* Update in keys

Co-authored-by: Andrew Nicolaou <me@andrewnicolaou.co.uk>
2020-07-31 15:20:42 +02:00
Cassie Tarakajian
937421e90c [#1526] Add ellipsis to sidebar file names 2020-07-30 18:59:12 -04:00
ghalestrilo
de0e32f6a3 🚨 ignore proptype errors 2020-07-24 18:11:10 -03:00
ghalestrilo
ccbe96dfc2 🚚 move preferences creators to components/Preferences 2020-07-21 18:18:19 -03:00
ghalestrilo
b55bec18d4 ♻️ use connected <Console /> on IDEView 2020-07-16 18:20:52 -03:00
Cassie Tarakajian
decf4a9c4d [#1458] Fix merge bug, rename handler function
- Fix bug in warnIfUnsavedChanges that referred to this.props by
  changing it to props
- Change function name from `warnIfUnsavedChangesCaller` to
  `handleUnsavedChanges`, remove it being called via binding/arrow func
2020-07-09 12:50:46 -04:00
Cassie Tarakajian
e666b46e7c Merge branch 'develop' into refactorIDEView 2020-07-09 12:37:03 -04:00
Sai Jatin K
1a78cebd3b
replaced anonymous function with named function: warnIfUnsavedChangesCaller 2020-07-07 00:31:56 +05:30
Cassie Tarakajian
67e132d4eb Merge branch 'develop' into chore/split-test-runners 2020-07-06 12:38:22 -04:00
ov
b05d1b1a02
Prototype with proposed i18n architecture (#1478)
* Branch with i18n functionality
* Translation files with new entries
* includes Loader in index.jsx
* Uses WithTranslation In Nav
* New Namespace
* Shortcuts Modal Complete
* Preferences complete
* About overlay title translated
2020-07-06 11:36:45 +02:00
Sai Jatin K
707db59458
refactor-warnIfUnsavedChanges #1458 2020-07-02 17:58:45 +05:30
Sai Jatin K
d99afcccc5
changed syntax of top level functions 2020-06-30 01:57:31 +05:30
Andrew Nicolaou
9d55fa378a Use testing-library instead of enzyme for tests 2020-06-28 15:44:00 +02:00
Sai Jatin K
6a429cc3f0
Refactored getTitle and isUserOwner #1458 2020-06-20 20:01:15 +05:30
Sai Jatin K
26bdef9a3d
Refactored getTitle and isUserOwner #1458 2020-06-19 20:18:58 +05:30
Cassie Tarakajian
90195f4dd0
Merge pull request #1436 from processing/slug-api-endpoint
Fixes #1409 - adds username to url when fetching sketch from editor API
2020-05-28 13:39:29 -04:00
Cassie Tarakajian
b929e77952 Fixes #1425 - Removes sketch title from <title> for unsaved, new sketch 2020-05-26 18:05:35 -04:00
Cassie Tarakajian
47e798a7e6 Fixes #1409 - adds username to url when fetching sketch from editor API 2020-05-26 17:35:13 -04:00
Cassie Tarakajian
a0cb035dd4 Add <main> to all pages, add semantic HTML updates 2020-05-19 15:34:00 -04:00
shakti97
b16f628352 Enhancement(Esc key hide modal) 2020-04-24 00:29:33 +05:30
shakti97
0f8b489af2 added toggle console keyboard shortcut to keyboard shortcut overlay 2020-04-10 12:03:22 +05:30
shakti97
d666d17e9c Added Shortcut Toggle Console 2020-04-10 11:56:50 +05:30
Cassie Tarakajian
4eda1654c5
Merge pull request #1283 from shakti97/sidebar-shortcut
Feature sidebar toggle shortcut
2020-04-09 16:39:15 -04:00
Cassie Tarakajian
7c1aa2e589 Fix merge conflicts for cherry picking 0bac332a9eb360978e686d6be8bff92f0fa1740c 2020-03-03 14:42:51 -05:00
Cassie Tarakajian
b8fb51d283 Fix merge conflict for cherry-picking 0b8e78df3a0c49d5dcf706b1c26346da3dcc0bc4 2020-03-03 14:04:14 -05:00
shakti97
9d0603b6d5 Feature sidebar toggle shortcut 2020-02-24 00:18:16 +05:30
Gabriel Sroka
f3e8b81cb7 Update IDEView.jsx
`<Overlay...` has a default `title` of `'Modal'`
https://github.com/processing/p5.js-web-editor/blob/master/client/modules/App/components/Overlay.jsx#L102

many modals are missing a title, so i added some. i made them basically the same as the `ariaLabel` (but capitalized, changed `-` to ` `, etc)
2020-01-28 16:56:44 -05:00
Andrew Nicolaou
0660031a0c Make "Add sketch" copy consistent
Buttons and menu items should say "Add sketch" (singular) and titles
should say "Add to collection" as it's implied by context that it's
a sketch.
2020-01-15 10:50:17 +01:00
Gabriel Sroka
dabcccc494
Update IDEView.jsx
`<Overlay...` has a default `title` of `'Modal'`
https://github.com/processing/p5.js-web-editor/blob/master/client/modules/App/components/Overlay.jsx#L102

many modals are missing a title, so i added some. i made them basically the same as the `ariaLabel` (but capitalized, changed `-` to ` `, etc)
2019-12-29 15:43:06 -08:00
Andrew Nicolaou
0c68327690 Fixed-height Overlay for QuickAdd views 2019-12-11 15:12:00 +01:00
Andrew Nicolaou
387cec1988 Merge branch 'feature/sketch-collections' of https://github.com/andrewn/p5.js-web-editor into feature/sketch-collections 2019-11-25 21:51:14 +01:00
Andrew Nicolaou
4f7c9f24b8 Rename import to match file name 2019-11-25 21:19:22 +01:00
Cassie Tarakajian
5319bbbeb7 merge master into sketch collections, to include updating theming 2019-11-25 10:46:28 -05:00
Andrew Nicolaou
0d1a4d25f6 Keep theme in sync with state across the app 2019-11-25 13:38:58 +01:00
Andrew Nicolaou
13c45490a2 Merge branch 'feature/public-api' into feature/sketch-collections 2019-11-10 22:12:14 +01:00
Andrew Nicolaou
212ad64bae Implement CollectionSearchbar in addition to SketchSearchbar 2019-11-10 21:57:11 +01:00
Andrew Nicolaou
08fd6b826d New simplfied collection list when adding a sketch 2019-11-05 18:23:57 +01:00
Cassie Tarakajian
57ecfb7e1e fixes #1206, removes titles where it is unnecesary 2019-10-31 17:27:23 -04:00
Andrew Nicolaou
14a8f48fd5 Fix all linting errors/warnings 2019-10-21 10:35:20 +02:00
Andrew Nicolaou
38f13c2047 Remove modals from IDEView now that they are part of DashboardView 2019-10-02 18:17:32 +03:00
Andrew Nicolaou
f98919e69b Logged in user can use "Add to collection" menu item 2019-09-25 12:07:17 -04:00
Andrew Nicolaou
6ca6e78a28 Displays existing collection
- List all collections for a given user
- View an individual collection
- Link to a sketch from a collection
2019-09-25 12:06:07 -04:00
Rick Brown
5695830361 add ability to toggle line numbers to accessibility settings. Fixes #1138 (#1146)
* Added SET_LINE_NUMBERS constant

* Added setLineNumbers()

* Added lineNumber prop

* Added functionality to Preferences

* Passing props

* handle case SET_LINE_NUMBERS

* add lineNumber default value to the schema
2019-08-30 12:36:34 -04:00
raclim
3d779734c3 Searchbar (#1132)
* search bar function

* Fixes #231, adds searchbar to sketchlist

* Fixes #231, update requested changes to searchbar

* Fixes #231, reset search term after modal closed
2019-08-21 14:08:08 -04:00
Laksh Singla
735adcfa05 Update sketch list styling (#819)
* parent b3c3efcec9
author Laksh Singla <lakshsingla@gmail.com> 1549106083 +0530
committer Cassie Tarakajian <ctarakajian@gmail.com> 1560540243 -0400

parent b3c3efcec9
author Laksh Singla <lakshsingla@gmail.com> 1549106083 +0530
committer Cassie Tarakajian <ctarakajian@gmail.com> 1560540198 -0400

parent b3c3efcec9
author Laksh Singla <lakshsingla@gmail.com> 1549106083 +0530
committer Cassie Tarakajian <ctarakajian@gmail.com> 1560539667 -0400

Created initial html structure and styling for new SketchList design

Final styling of ActionDialogueBox commplete

Dropdown menu disappearing while clicking anywhere on the table

Fixed linting issues and renamed variables

Minor tweaks in the SketchList dropdown dialogue UI

Themifyed the dropdown

Made changes in the dropdown: Arrow positioned slightly updwards, Removed blank space and added box-shadow in dropdown, themifyed dropdowns dashed border color

Added Delete and Share functionality to Dialog box

Added Duplicate functionality to Dialog box

Added download functionality to Dialog box

SketchList does not open a sketch if dialogue box is opened

SketchList Rename initial UI completed

Enter key handled for rename project option

[WIP] Updating rename functionality

Download option now working for all the sketches

Duplicate functionality extended for non opened sketches too

Modified overlay behaviour to close only the last overlay

Share modal can now display different projects

Dropdown closes when Share and Delete are closing for a more natural UX

fix broken files from rebasing

Created initial html structure and styling for new SketchList design

Final styling of ActionDialogueBox commplete

Added Delete and Share functionality to Dialog box

Added Duplicate functionality to Dialog box

[WIP] Updating rename functionality

Duplicate functionality extended for non opened sketches too

Modified overlay behaviour to close only the last overlay

Share modal can now display different projects

Final styling of ActionDialogueBox commplete

Fixed linting issues and renamed variables

Minor tweaks in the SketchList dropdown dialogue UI

Themifyed the dropdown

Added Delete and Share functionality to Dialog box

[WIP] Updating rename functionality

Modified overlay behaviour to close only the last overlay

Share modal can now display different projects

Dropdown closes when Share and Delete are closing for a more natural UX

fix broken files from rebasing

Final styling of ActionDialogueBox commplete

Minor tweaks in the SketchList dropdown dialogue UI

Themifyed the dropdown

[WIP] Updating rename functionality

Duplicate functionality extended for non opened sketches too

Modified overlay behaviour to close only the last overlay

Share modal can now display different projects

Dropdown closes when Share and Delete are closing for a more natural UX

* fix bugs in merge commit

* move sketch list dialogue to ul/li

* update sketch option dropdown to use dropdown placeholder, remove unused css

* major refactor of sketchlist component, fix showShareModal action, minor updates ot icon sizing

* fix broken links on asset list

* remove unused image, fix options for different users in sketch list
2019-06-19 16:21:25 -04:00
Cassie Tarakajian
d4cdd1b790
fixes #1061, sets selected file if it gets unset (#1066) 2019-05-06 14:50:28 -04:00