From 5c36771c9502f846ef418131169330c7fd6eba48 Mon Sep 17 00:00:00 2001 From: Robin Gagnon Date: Fri, 24 Jul 2020 20:51:40 -0400 Subject: [PATCH 1/7] Fix typo in installation developer docs --- developer_docs/installation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/developer_docs/installation.md b/developer_docs/installation.md index 047f21d1..e665e48c 100644 --- a/developer_docs/installation.md +++ b/developer_docs/installation.md @@ -25,7 +25,7 @@ _Note_: The installation steps assume you are using a Unix-like shell. If you ar * For Mac OSX with [homebrew](http://brew.sh/): `brew tap mongodb/brew` then `brew install mongodb-community` and finally start the server with `brew services start mongodb-community` or you can visit the installation guide here [Installation Guide For MacOS](https://docs.mongodb.com/manual/tutorial/install-mongodb-on-os-x/) * For Windows and Linux: [MongoDB Installation](https://docs.mongodb.com/manual/installation/) 7. `$ cp .env.example .env` -8. (Optional) Update `.env` with necessary keys to enable certain app behavoirs, i.e. add Github ID and Github Secret if you want to be able to log in with Github. +8. (Optional) Update `.env` with necessary keys to enable certain app behaviors, i.e. add Github ID and Github Secret if you want to be able to log in with Github. 9. `$ npm run fetch-examples` - this downloads the example sketches into a user called 'p5' 10. `$ npm start` 11. Navigate to [http://localhost:8000](http://localhost:8000) in your browser From e299bf2a396eec92c93158685bca1fd22f2bff38 Mon Sep 17 00:00:00 2001 From: Sundeep Chand Date: Mon, 27 Jul 2020 23:47:51 +0530 Subject: [PATCH 2/7] fixed search result reset issue --- client/modules/IDE/components/Searchbar/Searchbar.jsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/client/modules/IDE/components/Searchbar/Searchbar.jsx b/client/modules/IDE/components/Searchbar/Searchbar.jsx index b81b3bea..cd9693bd 100644 --- a/client/modules/IDE/components/Searchbar/Searchbar.jsx +++ b/client/modules/IDE/components/Searchbar/Searchbar.jsx @@ -35,6 +35,11 @@ class Searchbar extends React.Component { }; handleSearchChange = (e) => { + if (e.target.value === '') { + // Manually reset the searchValue if the search field becomes empty. + this.handleResetSearch(); + return; + } this.setState({ searchValue: e.target.value }, () => { this.throttledSearchChange(this.state.searchValue); }); From cb3c82475b0689e768b018ad18b189479ba449f2 Mon Sep 17 00:00:00 2001 From: Robin Gagnon Date: Fri, 24 Jul 2020 20:51:40 -0400 Subject: [PATCH 3/7] Fix typo in installation developer docs --- developer_docs/installation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/developer_docs/installation.md b/developer_docs/installation.md index fce3e44f..2a788c02 100644 --- a/developer_docs/installation.md +++ b/developer_docs/installation.md @@ -25,7 +25,7 @@ _Note_: The installation steps assume you are using a Unix-like shell. If you ar * For Mac OSX with [homebrew](http://brew.sh/): `brew tap mongodb/brew` then `brew install mongodb-community` and finally start the server with `brew services start mongodb-community` or you can visit the installation guide here [Installation Guide For MacOS](https://docs.mongodb.com/manual/tutorial/install-mongodb-on-os-x/) * For Windows and Linux: [MongoDB Installation](https://docs.mongodb.com/manual/installation/) 7. `$ cp .env.example .env` -8. (Optional) Update `.env` with necessary keys to enable certain app behavoirs, i.e. add Github ID and Github Secret if you want to be able to log in with Github. +8. (Optional) Update `.env` with necessary keys to enable certain app behaviors, i.e. add Github ID and Github Secret if you want to be able to log in with Github. 9. `$ npm run fetch-examples` - this downloads the example sketches into a user called 'p5' 10. `$ npm start` 11. Navigate to [http://localhost:8000](http://localhost:8000) in your browser From dab1e5334e3e37d6b188c4d620acb07cf8c8d4c2 Mon Sep 17 00:00:00 2001 From: Sundeep Chand Date: Mon, 27 Jul 2020 23:47:51 +0530 Subject: [PATCH 4/7] fixed search result reset issue --- client/modules/IDE/components/Searchbar/Searchbar.jsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/client/modules/IDE/components/Searchbar/Searchbar.jsx b/client/modules/IDE/components/Searchbar/Searchbar.jsx index b81b3bea..cd9693bd 100644 --- a/client/modules/IDE/components/Searchbar/Searchbar.jsx +++ b/client/modules/IDE/components/Searchbar/Searchbar.jsx @@ -35,6 +35,11 @@ class Searchbar extends React.Component { }; handleSearchChange = (e) => { + if (e.target.value === '') { + // Manually reset the searchValue if the search field becomes empty. + this.handleResetSearch(); + return; + } this.setState({ searchValue: e.target.value }, () => { this.throttledSearchChange(this.state.searchValue); }); From 9470fd12ffc9c51e2809373e5cc0c2a8cd354219 Mon Sep 17 00:00:00 2001 From: Cassie Tarakajian Date: Mon, 27 Jul 2020 18:11:18 -0400 Subject: [PATCH 5/7] [#1512] Update searchbar to query with empty term --- client/modules/IDE/components/Searchbar/Searchbar.jsx | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/client/modules/IDE/components/Searchbar/Searchbar.jsx b/client/modules/IDE/components/Searchbar/Searchbar.jsx index cd9693bd..a258fa13 100644 --- a/client/modules/IDE/components/Searchbar/Searchbar.jsx +++ b/client/modules/IDE/components/Searchbar/Searchbar.jsx @@ -30,18 +30,12 @@ class Searchbar extends React.Component { } searchChange = () => { - if (this.state.searchValue.trim().length === 0) return; this.props.setSearchTerm(this.state.searchValue.trim()); }; handleSearchChange = (e) => { - if (e.target.value === '') { - // Manually reset the searchValue if the search field becomes empty. - this.handleResetSearch(); - return; - } this.setState({ searchValue: e.target.value }, () => { - this.throttledSearchChange(this.state.searchValue); + this.throttledSearchChange(this.state.searchValue.trim()); }); } From 1091a4e4af0731769e9768fb0137feb6f7cb66e9 Mon Sep 17 00:00:00 2001 From: Sundeep Chand Date: Tue, 28 Jul 2020 12:48:52 +0530 Subject: [PATCH 6/7] Update searchbar to query with empty term --- .../IDE/components/Searchbar/Searchbar.jsx | 20 +++++++------------ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/client/modules/IDE/components/Searchbar/Searchbar.jsx b/client/modules/IDE/components/Searchbar/Searchbar.jsx index cd9693bd..3b9c92c0 100644 --- a/client/modules/IDE/components/Searchbar/Searchbar.jsx +++ b/client/modules/IDE/components/Searchbar/Searchbar.jsx @@ -23,25 +23,19 @@ class Searchbar extends React.Component { }); } - handleSearchEnter = (e) => { - if (e.key === 'Enter') { - this.searchChange(); - } - } + // handleSearchEnter = (e) => { + // if (e.key === 'Enter') { + // this.searchChange(); + // } + // } searchChange = () => { - if (this.state.searchValue.trim().length === 0) return; this.props.setSearchTerm(this.state.searchValue.trim()); }; handleSearchChange = (e) => { - if (e.target.value === '') { - // Manually reset the searchValue if the search field becomes empty. - this.handleResetSearch(); - return; - } this.setState({ searchValue: e.target.value }, () => { - this.throttledSearchChange(this.state.searchValue); + this.throttledSearchChange(this.state.searchValue.trim()); }); } @@ -58,7 +52,7 @@ class Searchbar extends React.Component { value={searchValue} placeholder={this.props.searchLabel} onChange={this.handleSearchChange} - onKeyUp={this.handleSearchEnter} + // onKeyUp={this.handleSearchEnter} />