r/p5.js-web-editor
1
0
Fork 0
Code Issues 1 Pull requests Releases 1 Wiki Activity

Update IDEView.jsx

Browse source 
`<Overlay...` has a default `title` of `'Modal'`
https://github.com/processing/p5.js-web-editor/blob/master/client/modules/App/components/Overlay.jsx#L102

many modals are missing a title, so i added some. i made them basically the same as the `ariaLabel` (but capitalized, changed `-` to ` `, etc)
This commit is contained in:
Gabriel Sroka 2019-12-29 15:43:06 -08:00 committed by GitHub
parent 3357af6df9
commit dabcccc494
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
client/modules/IDE/pages/IDEView.jsx
View file

@ -191,6 +191,7 @@ class IDEView extends React.Component {
<Toolbar /> <Toolbar />
{this.props.ide.preferencesIsVisible && {this.props.ide.preferencesIsVisible &&
<Overlay <Overlay
title="Settings"
ariaLabel="settings" ariaLabel="settings"
closeOverlay={this.props.closePreferences} closeOverlay={this.props.closePreferences}
> >
@ -389,6 +390,7 @@ class IDEView extends React.Component {
} }
{ this.props.location.pathname === '/about' && { this.props.location.pathname === '/about' &&
<Overlay <Overlay
title="About"
previousPath={this.props.ide.previousPath} previousPath={this.props.ide.previousPath}
ariaLabel="about" ariaLabel="about"
> >
@ -397,6 +399,7 @@ class IDEView extends React.Component {
} }
{ this.props.location.pathname === '/feedback' && { this.props.location.pathname === '/feedback' &&
<Overlay <Overlay
title="Submit Feedback"
previousPath={this.props.ide.previousPath} previousPath={this.props.ide.previousPath}
ariaLabel="submit-feedback" ariaLabel="submit-feedback"
> >
@ -405,6 +408,7 @@ class IDEView extends React.Component {
} }
{ this.props.ide.shareModalVisible && { this.props.ide.shareModalVisible &&
<Overlay <Overlay
title="Share"
ariaLabel="share" ariaLabel="share"
closeOverlay={this.props.closeShareModal} closeOverlay={this.props.closeShareModal}
> >
@ -417,6 +421,7 @@ class IDEView extends React.Component {
} }
{ this.props.ide.keyboardShortcutVisible && { this.props.ide.keyboardShortcutVisible &&
<Overlay <Overlay
title="Keyboard Shortcuts"
ariaLabel="keyboard shortcuts" ariaLabel="keyboard shortcuts"
closeOverlay={this.props.closeKeyboardShortcutModal} closeOverlay={this.props.closeKeyboardShortcutModal}
> >
@ -425,6 +430,7 @@ class IDEView extends React.Component {
} }
{ this.props.ide.errorType && { this.props.ide.errorType &&
<Overlay <Overlay
title="Error"
ariaLabel="error" ariaLabel="error"
closeOverlay={this.props.hideErrorModal} closeOverlay={this.props.hideErrorModal}
> >