fix #190, also fix bug in which fontSize and indentation amount could be NaN
This commit is contained in:
parent
d082ada1fd
commit
c7483b5d3a
1 changed files with 22 additions and 2 deletions
|
@ -9,19 +9,31 @@ const exitUrl = require('../../../images/exit.svg');
|
||||||
const plusUrl = require('../../../images/plus.svg');
|
const plusUrl = require('../../../images/plus.svg');
|
||||||
const minusUrl = require('../../../images/minus.svg');
|
const minusUrl = require('../../../images/minus.svg');
|
||||||
const beepUrl = require('../../../sounds/audioAlert.mp3');
|
const beepUrl = require('../../../sounds/audioAlert.mp3');
|
||||||
|
// import { debounce } from 'lodash';
|
||||||
|
|
||||||
class Preferences extends React.Component {
|
class Preferences extends React.Component {
|
||||||
constructor(props) {
|
constructor(props) {
|
||||||
super(props);
|
super(props);
|
||||||
this.handleUpdateAutosave = this.handleUpdateAutosave.bind(this);
|
this.handleUpdateAutosave = this.handleUpdateAutosave.bind(this);
|
||||||
|
this.handleUpdateFont = this.handleUpdateFont.bind(this);
|
||||||
|
this.handleUpdateIndentation = this.handleUpdateIndentation.bind(this);
|
||||||
|
this.handleLintWarning = this.handleLintWarning.bind(this);
|
||||||
}
|
}
|
||||||
|
|
||||||
handleUpdateFont(event) {
|
handleUpdateFont(event) {
|
||||||
this.props.setFontSize(parseInt(event.target.value, 10));
|
let value = parseInt(event.target.value, 10);
|
||||||
|
if (isNaN(value)) {
|
||||||
|
value = 16;
|
||||||
|
}
|
||||||
|
this.props.setFontSize(value);
|
||||||
}
|
}
|
||||||
|
|
||||||
handleUpdateIndentation(event) {
|
handleUpdateIndentation(event) {
|
||||||
this.props.setIndentation(parseInt(event.target.value, 10));
|
let value = parseInt(event.target.value, 10);
|
||||||
|
if (isNaN(value)) {
|
||||||
|
value = 2;
|
||||||
|
}
|
||||||
|
this.props.setIndentation(value);
|
||||||
}
|
}
|
||||||
|
|
||||||
handleUpdateAutosave(event) {
|
handleUpdateAutosave(event) {
|
||||||
|
@ -73,6 +85,10 @@ class Preferences extends React.Component {
|
||||||
role="status"
|
role="status"
|
||||||
value={this.props.fontSize}
|
value={this.props.fontSize}
|
||||||
onChange={this.handleUpdateFont}
|
onChange={this.handleUpdateFont}
|
||||||
|
ref="fontSizeInput"
|
||||||
|
onClick={() => {
|
||||||
|
this.refs.fontSizeInput.select();
|
||||||
|
}}
|
||||||
>
|
>
|
||||||
</input>
|
</input>
|
||||||
<button
|
<button
|
||||||
|
@ -103,6 +119,10 @@ class Preferences extends React.Component {
|
||||||
role="status"
|
role="status"
|
||||||
value={this.props.indentationAmount}
|
value={this.props.indentationAmount}
|
||||||
onChange={this.handleUpdateIndentation}
|
onChange={this.handleUpdateIndentation}
|
||||||
|
ref="indentationInput"
|
||||||
|
onClick={() => {
|
||||||
|
this.refs.indentationInput.select();
|
||||||
|
}}
|
||||||
>
|
>
|
||||||
</input>
|
</input>
|
||||||
<button
|
<button
|
||||||
|
|
Loading…
Reference in a new issue