From f4d49f49a5b6523fa6113d9ceee4b3f6018d20b1 Mon Sep 17 00:00:00 2001 From: MathuraMG Date: Sat, 30 Jul 2016 22:46:48 -0400 Subject: [PATCH 1/4] add aria-label tag --- client/modules/IDE/components/Console.js | 10 ++++---- client/modules/IDE/components/NewFileForm.js | 2 +- client/modules/IDE/components/Preferences.js | 25 ++++++-------------- client/modules/IDE/components/Sidebar.js | 15 +++++++----- client/modules/IDE/components/Toolbar.js | 16 ++++--------- client/styles/abstracts/_placeholders.scss | 9 ------- client/styles/components/_preferences.scss | 4 ---- client/styles/components/_toolbar.scss | 3 --- 8 files changed, 26 insertions(+), 58 deletions(-) diff --git a/client/modules/IDE/components/Console.js b/client/modules/IDE/components/Console.js index 5455f9d3..d5603a48 100644 --- a/client/modules/IDE/components/Console.js +++ b/client/modules/IDE/components/Console.js @@ -55,15 +55,15 @@ class Console extends React.Component { }); return ( -
+

console

- + +
{childrenToDisplay} diff --git a/client/modules/IDE/components/NewFileForm.js b/client/modules/IDE/components/NewFileForm.js index c46ca9e5..782c13a4 100644 --- a/client/modules/IDE/components/NewFileForm.js +++ b/client/modules/IDE/components/NewFileForm.js @@ -12,7 +12,7 @@ function NewFileForm(props) { placeholder="Name" {...name} /> - + ); } diff --git a/client/modules/IDE/components/Preferences.js b/client/modules/IDE/components/Preferences.js index a7ed6627..0827c0c7 100644 --- a/client/modules/IDE/components/Preferences.js +++ b/client/modules/IDE/components/Preferences.js @@ -27,6 +27,7 @@ function Preferences(props) { className="preferences__exit-button" onClick={props.closePreferences} title="exit" + aria-label="exit preferences" > @@ -37,14 +38,11 @@ function Preferences(props) { -
Increase
-
@@ -72,14 +67,11 @@ function Preferences(props) { -
Increase
-
- - + +
diff --git a/client/modules/IDE/components/Sidebar.js b/client/modules/IDE/components/Sidebar.js index 78119fc5..b680364a 100644 --- a/client/modules/IDE/components/Sidebar.js +++ b/client/modules/IDE/components/Sidebar.js @@ -15,24 +15,27 @@ function Sidebar(props) {

Sketch Files

- + - - +
    diff --git a/client/modules/IDE/components/Toolbar.js b/client/modules/IDE/components/Toolbar.js index da289b1b..660cc82a 100644 --- a/client/modules/IDE/components/Toolbar.js +++ b/client/modules/IDE/components/Toolbar.js @@ -23,18 +23,13 @@ function Toolbar(props) { return (
    p5js Logo - - - -
    -
    ); } diff --git a/client/styles/abstracts/_placeholders.scss b/client/styles/abstracts/_placeholders.scss index 785640a6..9675bb59 100644 --- a/client/styles/abstracts/_placeholders.scss +++ b/client/styles/abstracts/_placeholders.scss @@ -108,15 +108,6 @@ } } -%hidden-label { - position:absolute; - left:-10000px; - top:auto; - width:1px; - height:1px; - overflow:hidden; -} - %modal { background-color: $light-modal-background-color; border: 1px solid $light-modal-border-color; diff --git a/client/styles/components/_preferences.scss b/client/styles/components/_preferences.scss index 4ceb2a9b..fd6a3cf6 100644 --- a/client/styles/components/_preferences.scss +++ b/client/styles/components/_preferences.scss @@ -79,7 +79,3 @@ @extend %preference-option--selected; } } - -.preference__button-label { - @extend %hidden-label -} diff --git a/client/styles/components/_toolbar.scss b/client/styles/components/_toolbar.scss index cd62e28f..3716c907 100644 --- a/client/styles/components/_toolbar.scss +++ b/client/styles/components/_toolbar.scss @@ -55,9 +55,6 @@ } } -.toolbar__button-label { - @extend %hidden-label -} .toolbar__project-owner { margin-left: #{5 / $base-font-size}rem; } From ca9afab2467c9c40038b2d6155888d87e8a21671 Mon Sep 17 00:00:00 2001 From: MathuraMG Date: Sun, 31 Jul 2016 21:38:46 -0400 Subject: [PATCH 2/4] add aria-labels --- client/modules/User/components/LoginForm.js | 8 +++----- client/modules/User/components/SignupForm.js | 19 +++++-------------- client/styles/components/_console.scss | 4 +++- client/styles/components/_login.scss | 7 +------ client/styles/components/_sidebar.scss | 1 + client/styles/components/_signup.scss | 7 ------- 6 files changed, 13 insertions(+), 33 deletions(-) diff --git a/client/modules/User/components/LoginForm.js b/client/modules/User/components/LoginForm.js index c7ae778b..8ba3193b 100644 --- a/client/modules/User/components/LoginForm.js +++ b/client/modules/User/components/LoginForm.js @@ -5,26 +5,24 @@ function LoginForm(props) { return (

    -

    -

    - +
    ); } diff --git a/client/modules/User/components/SignupForm.js b/client/modules/User/components/SignupForm.js index abd6e3a5..c9872754 100644 --- a/client/modules/User/components/SignupForm.js +++ b/client/modules/User/components/SignupForm.js @@ -5,51 +5,42 @@ function SignupForm(props) { return (

    -

    -

    -

    -

    - +
    ); } diff --git a/client/styles/components/_console.scss b/client/styles/components/_console.scss index 6ca9b1fc..2b7b2151 100644 --- a/client/styles/components/_console.scss +++ b/client/styles/components/_console.scss @@ -54,14 +54,16 @@ } .preview-console__collapse { + @extend %icon; .preview-console--collapsed & { display: none; } } .preview-console__expand { + @extend %icon; display: none; .preview-console--collapsed & { display: inline-block; } -} \ No newline at end of file +} diff --git a/client/styles/components/_login.scss b/client/styles/components/_login.scss index 35ffef8b..44871382 100644 --- a/client/styles/components/_login.scss +++ b/client/styles/components/_login.scss @@ -6,12 +6,7 @@ justify-content: center; } -.login-form__email-label, -.login-form__password-label { - display: none; -} - -.login-form__email-input, +.login-form__email-input, .login-form__password-input { width: #{300 / $base-font-size}rem; } diff --git a/client/styles/components/_sidebar.scss b/client/styles/components/_sidebar.scss index 7919678f..5dcd5725 100644 --- a/client/styles/components/_sidebar.scss +++ b/client/styles/components/_sidebar.scss @@ -16,6 +16,7 @@ } .sidebar__add { + @extend %icon; cursor: pointer; height: #{26 / $base-font-size}rem; margin-right: #{16 / $base-font-size}rem; diff --git a/client/styles/components/_signup.scss b/client/styles/components/_signup.scss index 203bc729..6aee6e75 100644 --- a/client/styles/components/_signup.scss +++ b/client/styles/components/_signup.scss @@ -6,13 +6,6 @@ justify-content: center; } -.signup-form__username-label, -.signup-form__email-label, -.signup-form__password-label, -.signup-form__confirm-password-label { - display: none; -} - .signup-form__username-input, .signup-form__email-input, .signup-form__password-input, From 0bc2956e58d7dc4de7d9d4805600321ab107cb13 Mon Sep 17 00:00:00 2001 From: MathuraMG Date: Sun, 31 Jul 2016 21:41:28 -0400 Subject: [PATCH 3/4] add title to console --- client/modules/IDE/components/Console.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/modules/IDE/components/Console.js b/client/modules/IDE/components/Console.js index d5603a48..d201f557 100644 --- a/client/modules/IDE/components/Console.js +++ b/client/modules/IDE/components/Console.js @@ -55,7 +55,7 @@ class Console extends React.Component { }); return ( -
    +

    console