From 6a429cc3f037790e532069470e2ba69a5747b2c0 Mon Sep 17 00:00:00 2001 From: Sai Jatin K Date: Sat, 20 Jun 2020 20:01:15 +0530 Subject: [PATCH] Refactored getTitle and isUserOwner #1458 --- client/modules/IDE/pages/IDEView.jsx | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/client/modules/IDE/pages/IDEView.jsx b/client/modules/IDE/pages/IDEView.jsx index c427f4c5..92d7f996 100644 --- a/client/modules/IDE/pages/IDEView.jsx +++ b/client/modules/IDE/pages/IDEView.jsx @@ -34,6 +34,13 @@ import AddToCollectionList from '../components/AddToCollectionList'; import Feedback from '../components/Feedback'; import { CollectionSearchbar } from '../components/Searchbar'; +const getTitle = (props) => { + const { id } = props.project; + return id ? `p5.js Web Editor | ${props.project.name}` : 'p5.js Web Editor'; +}; + +const isUserOwner = props => props.project.owner && props.project.owner.id === props.user.id; + class IDEView extends React.Component { constructor(props) { super(props); @@ -92,7 +99,7 @@ class IDEView extends React.Component { } componentDidUpdate(prevProps) { - if (this.isUserOwner(this.props) && this.props.project.id) { + if (isUserOwner(this.props) && this.props.project.id) { if (this.props.preferences.autosave && this.props.ide.unsavedChanges && !this.props.ide.justOpenedProject) { if ( this.props.selectedFile.name === prevProps.selectedFile.name && @@ -123,19 +130,12 @@ class IDEView extends React.Component { this.autosaveInterval = null; } - getTitle = (props) => { - const { id } = props.project; - return id ? `p5.js Web Editor | ${props.project.name}` : 'p5.js Web Editor'; - } - - isUserOwner = props => props.project.owner && props.project.owner.id === props.user.id; - handleGlobalKeydown(e) { // 83 === s if (e.keyCode === 83 && ((e.metaKey && this.isMac) || (e.ctrlKey && !this.isMac))) { e.preventDefault(); e.stopPropagation(); - if (this.isUserOwner(this.props) || (this.props.user.authenticated && !this.props.project.owner)) { + if (isUserOwner(this.props) || (this.props.user.authenticated && !this.props.project.owner)) { this.props.saveProject(this.cmController.getContent()); } else if (this.props.user.authenticated) { this.props.cloneProject(); @@ -206,7 +206,7 @@ class IDEView extends React.Component { return (
- {this.getTitle(this.props)} + {getTitle(this.props)} {this.props.toast.isVisible && }