r/p5.js-web-editor
1
0
Fork 0
Code Issues 1 Pull requests Releases 1 Wiki Activity

Merge pull request #82 from lmccart/console

Browse source 
fixing console.log outside setup/draw closes #78
This commit is contained in:
Cassie Tarakajian 2016-08-30 21:15:03 -04:00 committed by GitHub
commit 6a3f3a7cf0
1 changed files with 57 additions and 51 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
client/modules/IDE/components/PreviewFrame.js
View file

@ -4,7 +4,7 @@ import escapeStringRegexp from 'escape-string-regexp';
import srcDoc from 'srcdoc-polyfill'; import srcDoc from 'srcdoc-polyfill';
const startTag = 'filestart-'; const startTag = '@fs-';
function getAllScriptOffsets(htmlFile) { function getAllScriptOffsets(htmlFile) {
const offs = []; const offs = [];
@ -29,24 +29,9 @@ function getAllScriptOffsets(htmlFile) {
return offs; return offs;
} }
function hijackConsoleScript(offs) {
function hijackConsoleLogsScript() {
const s = `<script> const s = `<script>
function getScriptOff(line) {
var offs = ${offs};
var l = 0;
var file = '';
for (var i=0; i<offs.length; i++) {
var n = offs[i][0];
if (n < line && n > l) {
l = n;
file = offs[i][1];
}
}
return [line - l, file];
}
document.addEventListener('DOMContentLoaded', function() {
var iframeWindow = window; var iframeWindow = window;
var originalConsole = iframeWindow.console; var originalConsole = iframeWindow.console;
iframeWindow.console = {}; iframeWindow.console = {};
@ -62,7 +47,7 @@ function hijackConsoleScript(offs) {
var args = Array.from(arguments); var args = Array.from(arguments);
args = args.map(function(i) { args = args.map(function(i) {
// catch objects // catch objects
return (typeof i === 'undefined') ? 'undefined' : JSON.stringify(i); return (typeof i === 'string') ? i : JSON.stringify(i);
}); });
// post message to parent window // post message to parent window
@ -73,6 +58,24 @@ function hijackConsoleScript(offs) {
}, '*'); }, '*');
}; };
}); });
</script>`;
return s;
}
function hijackConsoleErrorsScript(offs) {
const s = `<script>
function getScriptOff(line) {
var offs = ${offs};
var l = 0;
var file = '';
for (var i=0; i<offs.length; i++) {
var n = offs[i][0];
if (n < line && n > l) {
l = n;
file = offs[i][1];
}
}
return [line - l, file];
}
// catch reference errors, via http://stackoverflow.com/a/12747364/2994108 // catch reference errors, via http://stackoverflow.com/a/12747364/2994108
window.onerror = function (msg, url, lineNumber, columnNo, error) { window.onerror = function (msg, url, lineNumber, columnNo, error) {
@ -93,7 +96,6 @@ function hijackConsoleScript(offs) {
}, '*'); }, '*');
return false; return false;
}; };
});
</script>`; </script>`;
return s; return s;
} }
@ -144,6 +146,9 @@ class PreviewFrame extends React.Component {
// have to build the array manually because the spread operator is only // have to build the array manually because the spread operator is only
// one level down... // one level down...
htmlFile = hijackConsoleLogsScript() + htmlFile;
const jsFiles = []; const jsFiles = [];
this.props.jsFiles.forEach(jsFile => { this.props.jsFiles.forEach(jsFile => {
const newJSFile = { ...jsFile }; const newJSFile = { ...jsFile };
@ -195,7 +200,8 @@ class PreviewFrame extends React.Component {
} }
scriptOffs = getAllScriptOffsets(htmlFile); scriptOffs = getAllScriptOffsets(htmlFile);
htmlFile += hijackConsoleScript(JSON.stringify(scriptOffs)); htmlFile += hijackConsoleErrorsScript(JSON.stringify(scriptOffs));
return htmlFile; return htmlFile;
} }