From 617cffc869d58d2360920b76632d21d785d99a35 Mon Sep 17 00:00:00 2001
From: Cassie Tarakajian <ctarakajian@gmail.com>
Date: Tue, 8 May 2018 18:35:18 -0700
Subject: [PATCH] fix many linting errors

---
 .eslintrc                                     | 19 ++++++++---
 .../modules/IDE/components/CopyableInput.jsx  |  4 +--
 .../IDE/components/EditorAccessibility.jsx    | 11 ++++---
 client/modules/User/actions.js                |  4 +--
 client/styles/components/_copyable-input.scss | 32 ++++++++-----------
 5 files changed, 38 insertions(+), 32 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index 7be0a9eb..f3aa91ab 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -6,11 +6,6 @@
     "node": true,
     "mocha": true
   },
-  "ecmaFeatures": {
-    "jsx": true,
-    "es6": true,
-    "classes": true
-  },
   "rules": {
     "linebreak-style": 0,
     "react/no-multi-comp": 0,
@@ -51,6 +46,20 @@
           "to"
         ]
       }
+    ],
+    "jsx-a11y/label-has-for": [
+      2,
+      {
+        "components": [
+          "Label"
+        ],
+        "required": {
+          "every": [
+            "id"
+          ]
+        },
+        "allowChildren": false
+      }
     ]
   },
   "plugins": [
diff --git a/client/modules/IDE/components/CopyableInput.jsx b/client/modules/IDE/components/CopyableInput.jsx
index a510781c..adac29bc 100644
--- a/client/modules/IDE/components/CopyableInput.jsx
+++ b/client/modules/IDE/components/CopyableInput.jsx
@@ -41,12 +41,12 @@ class CopyableInput extends React.Component {
           ref={(element) => { this.tooltip = element; }}
           onMouseLeave={this.onMouseLeaveHandler}
         >
-          <label className="copyable-input__label" htmlFor="copyable-input__value">
+          <label className="copyable-input__label" htmlFor={`copyable-input__value-${label}`}>
             {label}
             <input
               type="text"
               className="copyable-input__value"
-              id="copyable-input__value"
+              id={`copyable-input__value-${label}`}
               value={value}
               ref={(element) => { this.input = element; }}
               readOnly
diff --git a/client/modules/IDE/components/EditorAccessibility.jsx b/client/modules/IDE/components/EditorAccessibility.jsx
index ebaf841e..86ccde13 100644
--- a/client/modules/IDE/components/EditorAccessibility.jsx
+++ b/client/modules/IDE/components/EditorAccessibility.jsx
@@ -9,11 +9,12 @@ class EditorAccessibility extends React.Component {
     const messages = [];
     if (this.props.lintMessages.length > 0) {
       this.props.lintMessages.forEach((lintMessage, i) => {
-        messages.push(<li key={lintMessage.id}>
-          {lintMessage.severity} in line
-          {lintMessage.line} :
-          {lintMessage.message}
-        </li>);
+        messages.push((
+          <li key={lintMessage.id}>
+            {lintMessage.severity} in line
+            {lintMessage.line} :
+            {lintMessage.message}
+          </li>));
       });
     } else {
       messages.push(<li tabIndex="0" key={0}> There are no lint messages </li>);
diff --git a/client/modules/User/actions.js b/client/modules/User/actions.js
index a32adf87..68602968 100644
--- a/client/modules/User/actions.js
+++ b/client/modules/User/actions.js
@@ -63,7 +63,7 @@ export function validateAndLoginUser(previousPath, formProps, dispatch) {
         resolve();
       })
       .catch((response) => {
-        reject({ password: response.data.message, _error: 'Login failed!' });
+        reject({ password: response.data.message, _error: 'Login failed!' }); // eslint-disable-line
       });
   });
 }
@@ -212,5 +212,5 @@ export function updateSettings(formValues) {
         dispatch(updateSettingsSuccess(response.data));
         browserHistory.push('/');
       })
-      .catch(response => Promise.reject({ currentPassword: response.data.error }));
+      .catch(response => Promise.reject(new Error(response.data.error)));
 }
diff --git a/client/styles/components/_copyable-input.scss b/client/styles/components/_copyable-input.scss
index 49103b21..35b36db7 100644
--- a/client/styles/components/_copyable-input.scss
+++ b/client/styles/components/_copyable-input.scss
@@ -13,12 +13,12 @@
 .copyable-input__value {
   width: 100%;
   font-size: #{16 / $base-font-size}rem;
-  margin-top: #{5 / $base-font-size}rem;
 }
 
 .copyable-input__label {
   width: 100%;
   font-size: #{12 / $base-font-size}rem;
+  padding-bottom: #{5 / $base-font-size}rem;
   @include themify() {
     color: getThemifyVariable('inactive-text-color');
   }
@@ -34,24 +34,20 @@
   width: 100%;
 }
 
-.copyable-input {
-  .tooltipped::after {
-    @include themify() {
-      background-color: getThemifyVariable('button-background-hover-color');
-      color: getThemifyVariable('button-hover-color');
-    }
-    font-family: Montserrat, sans-serif;
-    font-size: #{12 / $base-font-size}rem;
-    bottom: #{41 / $base-font-size}rem;
+.tooltipped::after {
+  @include themify() {
+    background-color: getThemifyVariable('button-background-hover-color');
+    color: getThemifyVariable('button-hover-color');
   }
+  font-family: Montserrat, sans-serif;
+  font-size: #{12 / $base-font-size}rem;
+}
 
-  .tooltipped-n::before,
-  .tooltipped::before,
-  {
-    @include themify() {
-      color: getThemifyVariable('button-background-hover-color');
-      border-top-color: getThemifyVariable('button-background-hover-color');
-    }
-    top: #{14 / $base-font-size}rem;
+.tooltipped-n::before,
+.tooltipped::before,
+ {
+  @include themify() {
+    color: getThemifyVariable('button-background-hover-color');
+    border-top-color: getThemifyVariable('button-background-hover-color');
   }
 }
\ No newline at end of file