r/p5.js-web-editor
1
0
Fork 0
Code Issues 1 Pull requests Releases 1 Wiki Activity

Fixed my scrollbar mistake (#736)

Browse source 
* Fixed my scrollbar mistake

* Really fixed it by introducing a slightly different class for the fullview frame

* Using classnames module
This commit is contained in:
Basile Pesin 2018-10-22 20:59:08 +02:00 committed by Cassie Tarakajian
parent 924cd32992
commit 55dfd7e328
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
client/modules/IDE/components/PreviewFrame.jsx
View file

@ -7,6 +7,7 @@ import srcDoc from 'srcdoc-polyfill';
import loopProtect from 'loop-protect'; import loopProtect from 'loop-protect';
import { JSHINT } from 'jshint'; import { JSHINT } from 'jshint';
import decomment from 'decomment'; import decomment from 'decomment';
import classNames from 'classnames';
import { getBlobUrl } from '../actions/files'; import { getBlobUrl } from '../actions/files';
import { resolvePathToFile } from '../../../../server/utils/filePath'; import { resolvePathToFile } from '../../../../server/utils/filePath';
import { import {
@ -330,10 +331,14 @@ class PreviewFrame extends React.Component {
} }
render() { render() {
const iframeClass = classNames({
'preview-frame': true,
'preview-frame--full-view': this.props.fullView
});
return ( return (
<iframe <iframe
id="canvas_frame" id="canvas_frame"
className="preview-frame" className={iframeClass}
aria-label="sketch output" aria-label="sketch output"
role="main" role="main"
frameBorder="0" frameBorder="0"

4
client/styles/components/_preview-frame.scss
View file

@ -5,6 +5,10 @@
border-width: 0; border-width: 0;
} }
.preview-frame--full-view {
position: relative;
}
.preview-frame-holder { .preview-frame-holder {
display: flex; display: flex;
flex-direction: column; flex-direction: column;