From 6120655ef2283d82943f9e905498e244757071d7 Mon Sep 17 00:00:00 2001 From: shyash Date: Mon, 23 Dec 2019 17:12:10 +0530 Subject: [PATCH 1/5] align toolbar --- client/styles/components/_toolbar.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/client/styles/components/_toolbar.scss b/client/styles/components/_toolbar.scss index a7c81415..274cad11 100644 --- a/client/styles/components/_toolbar.scss +++ b/client/styles/components/_toolbar.scss @@ -68,6 +68,11 @@ align-items: center; } +.toolbar__autorefresh{ + display: flex; + align-items: center; +} + .toolbar__project-name-container { @include themify() { border-color: getThemifyVariable('inactive-text-color'); From 813b57d04b5aa9d4920c23f9529626025f68287e Mon Sep 17 00:00:00 2001 From: Gabriel Sroka Date: Sun, 29 Dec 2019 15:16:58 -0800 Subject: [PATCH 2/5] Update README.md --- developer_docs/README.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/developer_docs/README.md b/developer_docs/README.md index cf72650c..3586d5cb 100644 --- a/developer_docs/README.md +++ b/developer_docs/README.md @@ -1,13 +1,13 @@ This folder contains documents intended for developers of the p5.js Web Editor. ## List of Documents -* [Installation](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/installation.md) - A guide for setting up your development environment -* [Development](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/development.md) - A guide for adding code to the web editor -* [Preparing a pull-request](https://github.com/processing/p5.js/blob/master/developer_docs/preparing_a_pull_request.md) - Instructions for how to make a pull-request -* [Accessibility Guidelines](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/accessibility.md) - Guidelines for writing code to create an accessible application -* [Deployment](https://github.com/processing/p5.js-web-editor/blob/master/developer_docs/deployment.md) - A guide to production deployment, and all platforms that are being used. +* [Installation](installation.md) - A guide for setting up your development environment +* [Development](development.md) - A guide for adding code to the web editor +* [Preparing a pull-request](preparing_a_pull_request.md) - Instructions for how to make a pull-request +* [Accessibility Guidelines](accessibility.md) - Guidelines for writing code to create an accessible application +* [Deployment](deployment.md) - A guide to production deployment, and all platforms that are being used. ## Documents to Create * Design Principles - reference [p5.js design principles](https://github.com/processing/p5.js/edit/master/developer_docs/design_principles.md) * Issue Labels - reference [p5.js issue labels](https://github.com/processing/p5.js/blob/master/developer_docs/issue_labels.md) -* File Structure - An explanation of the file structure of this application. \ No newline at end of file +* File Structure - An explanation of the file structure of this application. From dabcccc4940049dad578745e9d9d7c096975c403 Mon Sep 17 00:00:00 2001 From: Gabriel Sroka Date: Sun, 29 Dec 2019 15:43:06 -0800 Subject: [PATCH 3/5] Update IDEView.jsx ` {this.props.ide.preferencesIsVisible && @@ -389,6 +390,7 @@ class IDEView extends React.Component { } { this.props.location.pathname === '/about' && @@ -397,6 +399,7 @@ class IDEView extends React.Component { } { this.props.location.pathname === '/feedback' && @@ -405,6 +408,7 @@ class IDEView extends React.Component { } { this.props.ide.shareModalVisible && @@ -417,6 +421,7 @@ class IDEView extends React.Component { } { this.props.ide.keyboardShortcutVisible && @@ -425,6 +430,7 @@ class IDEView extends React.Component { } { this.props.ide.errorType && From a1cd362780e27b8a9f325e19d5d3dd5068f611ed Mon Sep 17 00:00:00 2001 From: amitch6097 Date: Sat, 4 Jan 2020 23:24:08 -0500 Subject: [PATCH 4/5] Fix p5 console being cleared on pause The p5 console was being cleared on pause not allowing a user to view what was outputed on the last run. To fix clearConsole function is now only called if playing. --- client/modules/IDE/components/PreviewFrame.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/modules/IDE/components/PreviewFrame.jsx b/client/modules/IDE/components/PreviewFrame.jsx index 45fa00fd..ef19c96d 100644 --- a/client/modules/IDE/components/PreviewFrame.jsx +++ b/client/modules/IDE/components/PreviewFrame.jsx @@ -334,10 +334,10 @@ class PreviewFrame extends React.Component { } renderSketch() { - this.props.clearConsole(); const doc = this.iframeElement; const localFiles = this.injectLocalFiles(); if (this.props.isPlaying) { + this.props.clearConsole(); srcDoc.set(doc, localFiles); if (this.props.endSketchRefresh) { this.props.endSketchRefresh(); From df27b36b0bd3ba91e0eeda91a03627a6067c07a0 Mon Sep 17 00:00:00 2001 From: Cassie Tarakajian Date: Wed, 8 Jan 2020 12:33:36 -0500 Subject: [PATCH 5/5] Fixes #914, aligns project name and autorefresh on Mac and Windows --- client/modules/IDE/components/Toolbar.jsx | 2 +- client/styles/components/_toolbar.scss | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/client/modules/IDE/components/Toolbar.jsx b/client/modules/IDE/components/Toolbar.jsx index 7e659a20..b331e10e 100644 --- a/client/modules/IDE/components/Toolbar.jsx +++ b/client/modules/IDE/components/Toolbar.jsx @@ -116,7 +116,7 @@ class Toolbar extends React.Component { } }} > - {this.props.project.name}  + {this.props.project.name} { this.canEditProjectName() && diff --git a/client/styles/components/_toolbar.scss b/client/styles/components/_toolbar.scss index 274cad11..86dec1b2 100644 --- a/client/styles/components/_toolbar.scss +++ b/client/styles/components/_toolbar.scss @@ -68,18 +68,12 @@ align-items: center; } -.toolbar__autorefresh{ - display: flex; - align-items: center; -} - .toolbar__project-name-container { @include themify() { border-color: getThemifyVariable('inactive-text-color'); } margin-left: #{10 / $base-font-size}rem; padding-left: #{10 / $base-font-size}rem; - height: 70%; display: flex; align-items: center; } @@ -95,7 +89,8 @@ } } cursor: pointer; - line-height: #{18 / $base-font-size}rem; + display: flex; + align-items: center; .toolbar__project-name-container--editing & { display: none; @@ -156,7 +151,6 @@ display: inline-block; vertical-align: top; height: #{18 / $base-font-size}rem; - margin-left: #{-4 / $base-font-size}rem; & svg { width: #{18 / $base-font-size}rem; height: #{18 / $base-font-size}rem;