From 234c4ffe14f4aa39bc0861b9dceb583582e6fbbb Mon Sep 17 00:00:00 2001 From: ghalestrilo Date: Mon, 20 Jul 2020 18:37:50 -0300 Subject: [PATCH] :bug: fix broken useState --- client/modules/IDE/components/Console.jsx | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/client/modules/IDE/components/Console.jsx b/client/modules/IDE/components/Console.jsx index c1596c89..258ae425 100644 --- a/client/modules/IDE/components/Console.jsx +++ b/client/modules/IDE/components/Console.jsx @@ -83,17 +83,11 @@ const getConsoleFeedStyle = (theme, times, fontSize) => { } }; -// 1 . FIXME: Object is not a function 🤷🏻 const Console = () => { const consoleEvents = useSelector(state => state.console); const isExpanded = useSelector(state => state.ide.consoleIsExpanded); const { theme, fontSize } = useSelector(state => state.preferences); - const [cm, setCm] = useState({}); - - // 2. FIXME: Console is not opening/closing, and I suspect it has to do with this - useDidUpdate(() => { if (cm) cm.scrollTop = cm.scrollHeight; }); - const { collapseConsole, expandConsole, clearConsole, dispatchConsoleEvent } = bindActionCreators({ ...IDEActions, ...ConsoleActions }, useDispatch()); @@ -101,11 +95,23 @@ const Console = () => { useDidUpdate(() => { clearConsole(); dispatchConsoleEvent(consoleEvents); - }, [theme, fontSize]); + }, [theme, fontSize]); // // const [consoleMessages, setConsoleMessages] = useState({}); // this.consoleMessages.scrollTop = this.consoleMessages.scrollHeight; + // const clearConsole = () => {}; + // const collapseConsole = () => {}; + // const expandConsole = () => {}; + + // const isExpanded = true; + // const fontSize = 16; + // const theme = {}; + + // // 2. FIXME: Console is not opening/closing, and I suspect it has to do with this + const cm = useRef({}); + useDidUpdate(() => { if (cm.current) cm.current.scrollTop = cm.current.scrollHeight; }); + const consoleClass = classNames({ 'preview-console': true, @@ -132,7 +138,7 @@ const Console = () => { -
setCm(element)} className="preview-console__messages"> +
{consoleEvents.map((consoleEvent) => { const { method, times } = consoleEvent; return (