From f13b9dcbbc2da50c116013c92e55e949dc5da33b Mon Sep 17 00:00:00 2001 From: shakti97 Date: Tue, 25 Feb 2020 23:22:52 +0530 Subject: [PATCH 1/2] fix redundant search button issue --- client/modules/IDE/components/Searchbar.jsx | 8 ++------ client/styles/components/_searchbar.scss | 4 +++- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/client/modules/IDE/components/Searchbar.jsx b/client/modules/IDE/components/Searchbar.jsx index f3047b91..db64fe65 100644 --- a/client/modules/IDE/components/Searchbar.jsx +++ b/client/modules/IDE/components/Searchbar.jsx @@ -47,13 +47,9 @@ class Searchbar extends React.Component { const { searchValue } = this.state; return (
- +
Date: Thu, 2 Apr 2020 15:54:40 -0400 Subject: [PATCH 2/2] Fixes #1290, change selector for search icon to work with div, remove unused styles --- client/styles/components/_searchbar.scss | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/client/styles/components/_searchbar.scss b/client/styles/components/_searchbar.scss index 042f3e7e..7076f75c 100644 --- a/client/styles/components/_searchbar.scss +++ b/client/styles/components/_searchbar.scss @@ -15,7 +15,7 @@ } } -button[type="submit"].searchbar__button { +div.searchbar__button { background-color: unset; width: #{31 / $base-font-size}rem; height: #{36 / $base-font-size}rem; @@ -29,15 +29,6 @@ button[type="submit"].searchbar__button { @include themify() { border-right-color: getThemifyVariable('input-border-color'); } - &:enabled:hover { - background-color: unset; - @include themify() { - border-right-color: getThemifyVariable('input-border-color'); - } - & g { - fill: unset; - } - } } .searchbar__icon { @@ -46,6 +37,7 @@ button[type="submit"].searchbar__button { width: #{22 / $base-font-size}rem; height: #{27 / $base-font-size}rem; transform: scaleX(-1); + padding-top: #{3 / $base-font-size}rem; @include themify() { fill: getThemifyVariable('input-text-color'); }