From b6d9c305602a555eb49f8f4a0d71905b7400e68a Mon Sep 17 00:00:00 2001
From: Ruben <rubenvandeven@gmail.com>
Date: Mon, 12 Sep 2016 00:08:37 +0100
Subject: [PATCH] Fancy achievementopmerking in review

---
 .idea/misc.xml                                              | 2 +-
 app/build.gradle                                            | 3 +--
 .../java/com/rubenvandeven/emotionhero/ReviewActivity.java  | 4 +++-
 app/src/main/res/layout/activity_review.xml                 | 6 +++---
 4 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/.idea/misc.xml b/.idea/misc.xml
index bd04605..1b77328 100644
--- a/.idea/misc.xml
+++ b/.idea/misc.xml
@@ -37,7 +37,7 @@
     <ConfirmationsSetting value="0" id="Add" />
     <ConfirmationsSetting value="0" id="Remove" />
   </component>
-  <component name="ProjectRootManager" version="2" languageLevel="JDK_1_7" default="true" assert-keyword="true" jdk-15="true" project-jdk-name="1.8" project-jdk-type="JavaSDK">
+  <component name="ProjectRootManager" version="2" languageLevel="JDK_1_8" default="true" assert-keyword="true" jdk-15="true" project-jdk-name="1.8" project-jdk-type="JavaSDK">
     <output url="file://$PROJECT_DIR$/build/classes" />
   </component>
   <component name="ProjectType">
diff --git a/app/build.gradle b/app/build.gradle
index 6c5e575..ee60818 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -10,7 +10,7 @@ android {
         minSdkVersion 16
         targetSdkVersion 23
         versionCode 1
-        versionName '0.1'
+        versionName '0.2'
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
 
         renderscriptTargetApi 16
@@ -40,5 +40,4 @@ dependencies {
     compile 'org.ocpsoft.prettytime:prettytime:4.0.1.Final'
     compile 'io.github.silvaren:easyrs:0.5.3'
     testCompile 'junit:junit:4.12'
-
 }
diff --git a/app/src/main/java/com/rubenvandeven/emotionhero/ReviewActivity.java b/app/src/main/java/com/rubenvandeven/emotionhero/ReviewActivity.java
index ece894d..6e91e42 100644
--- a/app/src/main/java/com/rubenvandeven/emotionhero/ReviewActivity.java
+++ b/app/src/main/java/com/rubenvandeven/emotionhero/ReviewActivity.java
@@ -86,7 +86,9 @@ public class ReviewActivity extends AppCompatActivity {
                             position.getInt("position");
 
                             scoreProgressBar.setVisibility(View.GONE);
-
+                            // TODO: pass the game to checkAchievements() to avoid crash on null error
+                            // means we have to load Player.getInstance form here and load the game
+                            // from given id to be save.
                             checkAchievements();
                         } catch (JSONException e) {
                             e.printStackTrace();
diff --git a/app/src/main/res/layout/activity_review.xml b/app/src/main/res/layout/activity_review.xml
index f6bcfae..5b6d0d5 100644
--- a/app/src/main/res/layout/activity_review.xml
+++ b/app/src/main/res/layout/activity_review.xml
@@ -144,7 +144,7 @@
             <RelativeLayout
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:background="@color/colorPrimaryDark"
+                android:background="@color/emotion_joy"
                 android:padding="@dimen/fab_margin"
                 android:layout_below="@+id/achievementTitle"
                 android:layout_alignParentLeft="true"
@@ -159,7 +159,7 @@
                     android:id="@+id/achievementText"
                     android:layout_toLeftOf="@+id/achievementArrow"
                     android:layout_centerInParent="true"
-                    android:textColor="@color/textHighlight"
+                    android:textColor="@color/textPrimary"
                     tools:text="No achievements." />
 
 
@@ -170,7 +170,7 @@
                     android:layout_alignParentRight="true"
                     android:layout_alignParentEnd="true"
                     android:id="@+id/achievementArrow"
-                    android:textColor="@color/textHighlight"
+                    android:textColor="@color/textPrimary"
                     android:textSize="36sp"
                     android:layout_centerInParent="true" />
             </RelativeLayout>